max_dist and max_dest for points_to_od() #48
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two new arguments to
points_to_od()
max_dist
lets you set the maximum distance e.g. 10,000m useful if you wanted to make a national OD matrix but only for local tripsmax_dest
lets you set the maximum number of destinations regardless of distance. E..g only to the 10 nearest destinations for each OD.Both method are very useful for large OD matrices as faster and use less memory.
Benchmark
This scales exponentially so for large ODs e.g. all LSOAs it makes a massive difference.
I've also added st_centriod to p & pd so non-point geometries can be used